Backport #1367 to Harmonic: Fix find Python3 logic and macOS workflow #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Find Python3 with find_package instead of GzPython, adapting the approach from gz-sim. * macos workflow: use brew --prefix, not /usr/local * macos workflow: set Python3_EXECUTABLE cmake var Signed-off-by: Steve Peters <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sdf14 #1368 +/- ##
=======================================
Coverage 92.40% 92.40%
=======================================
Files 134 134
Lines 17674 17674
=======================================
Hits 16332 16332
Misses 1342 1342 ☔ View full report in Codecov by Sentry. |
|
something's wrong with the python version in the macOS workflow; I'm going to try something... |
Signed-off-by: Steve Peters <[email protected]>
azeey
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
Backport #1367 to Harmonic. The patch applies cleanly to
sdf14but will require small modifications to backport tosdf13since Python3 was not required in Garden.Original commit message:
Fix find Python3 logic and macOS workflow
Note to maintainers: Remember to use Rebase-and-Merge.